RFR: JDK-8133818: Additional number of processed references printed with -XX:+PrintReferenceGC after JDK-8047125

[Tony Printezis]

Bengt and Ramki,

ShipIt

(FWIW, I had already reviewed it for Ramki internally but I did go over the webrev one more time)

On September 1, 2015 at 9:12:43 AM, Bengt Rutisson (bengt.rutisson at oracle.com) wrote:


Hi everyone, 

Could I have a couple of reviews for this patch contributed by Ramki? 

http://cr.openjdk.java.net/~brutisso/8133818/webrev.00/ 
https://bugs.openjdk.java.net/browse/JDK-8133818 

This changes the log format to print Cleaners separately from 
PhantomReferences. 

Old logging: 

#0: [PhantomReference, 0 refs, 0 refs, 0,0000433 secs] 

New logigng: 

#0: [PhantomReference, 0 refs, 0,0000797 secs]#0: [Cleaners, 0 refs, 
0,0000527 secs] 

It also adds the number of references processed for the JNI Weak 
References section. 

Old logging: 

#0: [JNI Weak Reference, 0,0000211 secs] 

New logging: 

#0: [JNI Weak Reference, 0 refs, 0,0000401 secs] 

Here are full log entry examples with -XX:+PrintGCDetails 
-XX:+PrintReferenceGC: 

Old logging: 

#0: [GC (System.gc()) #0: [SoftReference, 0 refs, 0,0000713 secs]#0: 
[WeakReference, 8 refs, 0,0000306 secs]#0: [FinalReference, 7 refs, 
0,0000445 secs]#0: [PhantomReference, 0 refs, 0 refs, 0,0000433 secs]#0: 
[JNI Weak Reference, 0,0000211 secs][PSYoungGen: 7741K->912K(150016K)] 
7741K->920K(493056K), 0,0053059 secs] [Times: user=0,05 sys=0,00 
real=0,00 secs] 


New logging: 

#0: [GC (System.gc()) #0: [SoftReference, 0 refs, 0,0001244 secs]#0: 
[WeakReference, 8 refs, 0,0001069 secs]#0: [FinalReference, 5 refs, 
0,0001086 secs]#0: [PhantomReference, 0 refs, 0,0000797 secs]#0: 
[Cleaners, 0 refs, 0,0000527 secs]#0: [JNI Weak Reference, 0 refs, 
0,0000401 secs][PSYoungGen: 2580K->768K(150016K)] 2580K->776K(493056K), 
0,0130553 secs] [Times: user=0,16 sys=0,01 real=0,01 secs] 


Unless there are larger changes suggested to this patch I will push this 
with Ramki as author. 

Thanks, 
Bengt 

-----

Tony Printezis | JVM/GC Engineer / VM Team | Twitter

@TonyPrintezis
tprintezis at twitter.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20150901/5c9fc4ca/attachment.htm>