RFR (S/M): 8169703: G1 crashes with guarantee(pretouch_gang != NULL) failed: No pretouch gang specified

[Dmitry Fazunenko]

Hi Thomas,

A few more comments about the tests:

1) would you fix indention to meet "4-space" rule for java.
2) TestParallelAlwaysPreTouch.java

a)

@run main ...
-->
@run main/othervm ...

b) You start one class, but declare another:
  * @run main -Xms10M -Xmx100m ...*TestAlwaysPreTouch*
public class*Test2GbHeap *{
...
}

c) Would it make sense to run a group of existing tests with "-XX:+AlwaysPreTouch" regularly (nightly or weekly)

Thanks,
Dima

On 18.11.2016 15:40, Thomas Schatzl wrote:
> Hi,
>
>    thanks for you looking into this...
>
> On Fri, 2016-11-18 at 15:24 +0300, Dmitry Dmitriev wrote:
>> Hi Thomas,
>>
>> Can comment only new test
>> test/gc/g1/TestSharedArchiveWithPreTouch.java:
>> 1) Can you please use different name for archive to avoid
>> intersection
>> with existing tests? E.g. "SharedArchiveWithPreTouch.jsa" instead of
>> "CDSCompressedKPtrs.jsa".
> Will fix and rerun jprt. I copy&pasted the name from the other tests :)
>
>> 2) Just interesting: Is it intended behavior of the test to use
>> UseCompressedClassPointers and UseCompressedOops?
> CDS is only supported with both options enabled on 64 bit systems. So
> the test needs to enable them manually.
>
> Thanks,
>    Thomas
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20161118/6dd6b41d/attachment.htm>