RFR: 8189390: Assert in TestOptionsWithRanges.java

[Stefan Karlsson]

Hi Roman,

Thanks for dealing with this so quickly.

This part is incorrect:

+ if (collector != NULL || !collector->completed_initialization()) {

it used to  be:

- if (collector == NULL || !collector->completed_initialization()) { No 
need to add a space after the !: if (! create_cms_collector()) Other 
than those to issues, this looks good.

StefanK

On 2017-10-18 19:21, Roman Kennke wrote:
> Apperently I yanked some error handling when extracting the CMSHeap 
> class from GenCollectedHeap, which makes TestOptionsWithRanges test fail.
>
> This puts the error handling back in exactly as it was before, which 
> makes the test happy:
>
> http://cr.openjdk.java.net/~rkennke/8189390/webrev.00/ 
> <http://cr.openjdk.java.net/%7Erkennke/8189390/webrev.00/>
>
> Ok?
>
> Roman
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20171018/673a4d9e/attachment.htm>