RFR (S): 8193312: Rename VM_CGC_Operation to VM_G1Concurrent
Thomas Schatzl
thomas.schatzl at oracle.com
Wed Dec 5 08:42:22 UTC 2018
Hi Per,
thanks for your review.
On Tue, 2018-12-04 at 21:38 +0100, Per Liden wrote:
> Hi Thomas,
>
> On 2018-12-04 17:39, Thomas Schatzl wrote:
> > Hi all,
> >
> > can I have reviews for this renaming of the VM operation classes
> > in G1 to something a bit more like the remaining code.
> >
> > I kept the VM_ prefix only for continuity with the parent class.
> >
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8193312
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8193312/webrev/
>
> There seems to be a naming mismatch, where you have
>
> + template(G1ConcurrentOperation) \
>
> and then
>
> +class VM_G1ConcurrentGCOperation : public VM_Operation {
>
> I.e. "G1ConcurrentGCOperation" vs "G1ConcurrentOperation".
>
> Looking at the list of other registered G1 operations, they are:
>
> template(G1CollectForAllocation) \
> template(G1CollectFull) \
>
> Just a suggestion, but I would leave out "GC" and "Operation", as the
> other G1 ops doesn't use that in their name, and just call it
> "G1Concurrent".
Done.
http://cr.openjdk.java.net/~tschatzl/8193312/webrev.0_to_1/ (diff)
http://cr.openjdk.java.net/~tschatzl/8193312/webrev.1/ (full)
Thomas
More information about the hotspot-gc-dev
mailing list