RFR 8204947: Port ShenandoahTaskTerminator to mainline and make it default

zgu at redhat.com zgu at redhat.com
Wed Dec 5 13:34:30 UTC 2018


> > > I also think what's being proposed here is more of a diagnostic
> > > than
> > > experimental flag.  I think an experimental flag ought to be opt-
> > > in,
> > > e.g. off by default but one can choose to take the risk.  A
> > > diagnostic
> > > flag can be used to opt-out of the "normal" behavior, in this
> > > case to
> > > revert back to the old behavior.  Of course, we violate that a
> > > lot...
> > 
> > I agree. Diagnostic seems to fit the purpose better.
> 
> Thanks for the suggestion, I changed the flag to diagnostic. Please
> see 
> updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.03
> /
> 
Ping!

I updated weberv to incorporate Thomas Schatzl's suggestions, mainly
are style and comment changes.

Incremental: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.04_inc/
Full: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.04/

Thanks,

-Zhengyu



> I also wanted to update CSR 
> (https://bugs.openjdk.java.net/browse/JDK-8214458) to reflect this 
> change, but I could not add comments, that made me wonder if I can 
> update text when it is in "provisional" status? or do I need to move 
> back to "draft" to do so?
> 
> Anyway, could you please review CSR also?
> 
> FYI:
>   Webrev02 passed vmTestbase_vm_gc and submit tests.
> 
> Thanks,
> 
> -Zhengyu
> 
> 
> 
> 
> 
> > 
> > Roman
> > 
> > 



More information about the hotspot-gc-dev mailing list