RFR 8204947: Port ShenandoahTaskTerminator to mainline and make it default

[Bernd Eckenfels]

There is a typo and I think you don’t  need to repeat the abbreviation:

"Use Optimized Work Stealing Threads task termination protocol"

In  gc_Globals.hpp


Gruss
Bernd
--
http://bernd.eckenfels.net

________________________________
Von: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> im Auftrag von zgu at redhat.com
Gesendet: Mittwoch, Dezember 5, 2018 3:34 PM
An: Roman Kennke; Kim Barrett; Thomas Schatzl
Cc: hotspot-gc-dev at openjdk.java.net
Betreff: Re: RFR 8204947: Port ShenandoahTaskTerminator to mainline and make it default


> > > I also think what's being proposed here is more of a diagnostic
> > > than
> > > experimental flag. I think an experimental flag ought to be opt-
> > > in,
> > > e.g. off by default but one can choose to take the risk. A
> > > diagnostic
> > > flag can be used to opt-out of the "normal" behavior, in this
> > > case to
> > > revert back to the old behavior. Of course, we violate that a
> > > lot...
> >
> > I agree. Diagnostic seems to fit the purpose better.
>
> Thanks for the suggestion, I changed the flag to diagnostic. Please
> see
> updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.03
> /
>
Ping!

I updated weberv to incorporate Thomas Schatzl's suggestions, mainly
are style and comment changes.

Incremental: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.04_inc/
Full: http://cr.openjdk.java.net/~zgu/JDK-8204947/webrev.04/

Thanks,

-Zhengyu



> I also wanted to update CSR
> (https://bugs.openjdk.java.net/browse/JDK-8214458) to reflect this
> change, but I could not add comments, that made me wonder if I can
> update text when it is in "provisional" status? or do I need to move
> back to "draft" to do so?
>
> Anyway, could you please review CSR also?
>
> FYI:
> Webrev02 passed vmTestbase_vm_gc and submit tests.
>
> Thanks,
>
> -Zhengyu
>
>
>
>
>
> >
> > Roman
> >
> >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20181205/99ab792f/attachment.htm>