RFR: JDK-8206407: Primitive atomic_cmpxchg_in_heap_at() in BarrierSet::Access needs to call non-oop raw method
Roman Kennke
rkennke at redhat.com
Thu Jul 5 15:00:38 UTC 2018
Hi Per,
>> BarrierSet::Access:atomic_cmpxchg_in_heap_at() is currently calling
>> Raw::oop_atomic_cmpxchg_at() which is obviously wrong.
>>
>> We've been lucky because primitive is not bound in default OpenJDK.
>>
>> Even in Shenandoah land we've been lucky because primitives don't match
>> narrowOop and thus don't get (attempted to) encoded/decoded.
>>
>> Lucky us.
>>
>> Let's fix it anyway:
>> http://cr.openjdk.java.net/~rkennke/JDK-8206407/webrev.00/
>
> Nice catch! Looks good!
Thanks for reviewing!
Does it qualify for trivial-doesn't-have-to-wait-24h-rule? I believe it
does, it's 1 line that is not even touched by default.
Roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180705/1f200217/signature.asc>
More information about the hotspot-gc-dev
mailing list