[8u-backport] RFR: JDK-8114823: G1 doesn't honor request to disable class unloading

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jul 19 13:27:02 UTC 2018


Hi Fairoz,

On Wed, 2018-07-18 at 23:52 -0700, Fairoz Matte wrote:
> Hi All,
> 
> Just a gentle reminder for review request.


- at g1RootProcessor.cpp:152, the call to process_string_table_roots()
should be moved to after the process_vm_roots() to (as much as
possible) keep in sync with JDK9 code.

- in G1RootProcessor::process_string_table_roots(), the "if (weak_roots
!= NULL)" is superfluous given the assert above it (and better keeps in
sync with JDK9 code).

Otherwise looks good to me.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list