[8u-backport] RFR: JDK-8114823: G1 doesn't honor request to disable class unloading
Fairoz Matte
fairoz.matte at oracle.com
Thu Jul 19 15:34:28 UTC 2018
Hi Thomas,
Thanks for the review.
Here is the updated webrev http://cr.openjdk.java.net/~fmatte/8114823/webrev.01/ with suggested changes.
Thanks,
Fairoz
> -----Original Message-----
> From: Thomas Schatzl
> Sent: Thursday, July 19, 2018 6:57 PM
> To: Fairoz Matte <fairoz.matte at oracle.com>; hotspot-gc-
> dev at openjdk.java.net
> Subject: Re: [8u-backport] RFR: JDK-8114823: G1 doesn't honor request to
> disable class unloading
>
> Hi Fairoz,
>
> On Wed, 2018-07-18 at 23:52 -0700, Fairoz Matte wrote:
> > Hi All,
> >
> > Just a gentle reminder for review request.
>
>
> - at g1RootProcessor.cpp:152, the call to process_string_table_roots() should
> be moved to after the process_vm_roots() to (as much as
> possible) keep in sync with JDK9 code.
>
> - in G1RootProcessor::process_string_table_roots(), the "if (weak_roots !=
> NULL)" is superfluous given the assert above it (and better keeps in sync with
> JDK9 code).
>
> Otherwise looks good to me.
>
> Thanks,
> Thomas
>
More information about the hotspot-gc-dev
mailing list