RFR (L) 8208246: flags duplications in vmTestbase_vm_g1classunloading tests

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jul 31 07:49:35 UTC 2018


Hi,

On Mon, 2018-07-30 at 12:34 -0700, JC Beyler wrote:
> Hi all,
> 
> Could I get a review for:
> 
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8208246/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8208246
> 
> Basically, I removed the duplicate flags in the various tests.
> 
> Additional notes due to the number of files changed: 
>   - I used an awk script to remove any duplicate line that was not
> just a empty commented line and occurred after a line
> containing @run.
>    - I then ran a script to check that all lines removed from the
> tests were still present in the test files (sanity check of my
> script)
>    - Finally, I ran the tests and they still pass via make run-test-
> only on my dev machine
> 

  looks good.

Thomas




More information about the hotspot-gc-dev mailing list