RFR (L) 8208246: flags duplications in vmTestbase_vm_g1classunloading tests

[Igor Ignatyev]

Hi JC,

the fix looks good to me. thanks for fixing it.

Cheers,
-- Igor

> On Jul 31, 2018, at 12:49 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On Mon, 2018-07-30 at 12:34 -0700, JC Beyler wrote:
>> Hi all,
>> 
>> Could I get a review for:
>> 
>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8208246/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8208246
>> 
>> Basically, I removed the duplicate flags in the various tests.
>> 
>> Additional notes due to the number of files changed: 
>>  - I used an awk script to remove any duplicate line that was not
>> just a empty commented line and occurred after a line
>> containing @run.
>>   - I then ran a script to check that all lines removed from the
>> tests were still present in the test files (sanity check of my
>> script)
>>   - Finally, I ran the tests and they still pass via make run-test-
>> only on my dev machine
>> 
> 
>  looks good.
> 
> Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180731/b7db9ac4/attachment.htm>