RFR (XL): 8202845: Refactor reference processing for improved parallelism
Kim Barrett
kim.barrett at oracle.com
Wed Jun 13 21:53:40 UTC 2018
> On Jun 13, 2018, at 5:26 PM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>
>>>
>>> http://cr.openjdk.java.net/~tschatzl/8202845/webrev.2_to_3 (diff)
>>> and
>>> http://cr.openjdk.java.net/~tschatzl/8202845/webrev.3 (full)
>>>
>>> Currently running hs-tier1-3, but I do not expect issues.
>>>
>
> No issues.
>
>>> Thomas
>>
>> Looks good, except verify_total_count_zero should be debug-only
>> rather than !PRODUCT.
>> In an “optimized" build it does nothing except waste time (calls
>> total_count but does nothing
>> with the result because assert is suppressed).
>
> I fixed that in place in the webrevs, replacing the NOT_PRODUCT_RETURN
> with a NOT_DEBUG_RETURN and the #ifndef PRODUCT with an #ifdef ASSERT.
>
> Thanks,
> Thomas
Looks good
More information about the hotspot-gc-dev
mailing list