RFR (XL): 8202845: Refactor reference processing for improved parallelism

[Stefan Johansson]

On 2018-06-13 23:53, Kim Barrett wrote:
>> On Jun 13, 2018, at 5:26 PM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>
>>>>
>>>> http://cr.openjdk.java.net/~tschatzl/8202845/webrev.2_to_3 (diff)
>>>> and
>>>> http://cr.openjdk.java.net/~tschatzl/8202845/webrev.3 (full)
>>>>
>>>> Currently running hs-tier1-3, but I do not expect issues.
>>>>
>>
>> No issues.
>>
>>>> Thomas
>>>
>>> Looks good, except verify_total_count_zero should be debug-only
>>> rather than !PRODUCT.
>>> In an “optimized" build it does nothing except waste time (calls
>>> total_count but does nothing
>>> with the result because assert is suppressed).
>>
>> I fixed that in place in the webrevs, replacing the NOT_PRODUCT_RETURN
>> with a NOT_DEBUG_RETURN and the #ifndef PRODUCT with an #ifdef ASSERT.
>>
>> Thanks,
>>   Thomas
> 
> Looks good
> 
Nice work guys!

Looks good to me too. Just one small thing in the test, might be nice to 
store the phase names in a variable since they are used more than once.

No need to see a new webrev for this.

Thanks,
Stefan