RFR(trivial): JDK-8221763: Build fails when using --with-jvm-features=-g1gc, -jfr, -shenandoahgc

[Ao Qi]

On Tue, Apr 2, 2019 at 9:26 AM Kim Barrett <kim.barrett at oracle.com> wrote:
>
> > On Apr 1, 2019, at 8:57 PM, Ao Qi <aoqi at loongson.cn> wrote:
> >
> > Thanks Kim Barrett.
> >
> > This patch is trivial, do I need another review? If not, could some
> > one help to push?
>
> Sorry, I didn’t notice that you aren’t a committer.
> A “trivial” HotSpot change only needs one Reviewer, and doesn’t need to wait 24 hours
> for other potential reviewers to chime in.  https://wiki.openjdk.java.net/display/HotSpot/HotSpot+How+To
>
> I’ll push this for you.

Thanks for the explanation and the push. I didn't know this page
before, and it is more clear to me now.

Cheers,
Ao Qi

>
> >
> > Thanks,
> > Ao Qi
> >
> > On Tue, Apr 2, 2019 at 12:56 AM Kim Barrett <kim.barrett at oracle.com> wrote:
> >>
> >>> On Apr 1, 2019, at 12:38 PM, Ao Qi <aoqi at loongson.cn> wrote:
> >>>
> >>> Hi,
> >>>
> >>> Build is broken when configure with
> >>> --with-jvm-features=-g1gc,-jfr,-shenandoahgc, since
> >>> gc/shared/softRefPolicy.hpp is missed.
> >>>
> >>> Could you please review this trivial patch?
> >>>
> >>> Bug:
> >>> https://bugs.openjdk.java.net/browse/JDK-8221763
> >>>
> >>> Webrev:
> >>> http://cr.openjdk.java.net/~aoqi/8221763/webrev.00
> >>>
> >>> Tested:
> >>> linux-x86_64-{server, minimal, zero}-{fastdebug, release} build,
> >>> linux-x86_64-{server, minimal, zero}-{fastdebug, release} build
> >>> (configure with -g1gc,-jfr,-shenandoahgc), linux-x86_64-server-release
> >>> hotspot:tier1_gc
> >>>
> >>> Thanks,
> >>> Ao Qi
> >>
> >> Looks good, and trivial.
>
>