RFR: JDK-8222333: fastdebug build broken after JDK-8221393

[Zhengyu Gu]

Hi Ao Qi,

1) Style does not match
    f(StringTableRoots,        "StringTable Roots(ms):")          \
+  f(Resolved_Method_TableRoots, "Resolved_Method_Table Roots(ms):")

'Resolved_Method_TableRoots' => ResolvedMethodTableRoots


2) This is a sub-phase, you also need corresponding phases, For example:

f(scan_jfr_weak_roots," S: JFR Weak Roots")            \
f(scan_jni_weak_roots," S: JNI Weak Roots")            \
f(scan_stringtable_roots," S: String Table Roots")        \
f(scan_resolved_method_table_roots, " S: Resolved Table Roots") \
f(scan_vm_weak_roots," S: VM Weak Roots")             \

Thanks,

-Zhengyu

On 4/11/19 7:07 AM, Ao Qi wrote:

> Hi,
>
> Bugs:
> https://bugs.openjdk.java.net/browse/JDK-8222333
>
> Webrev:
> http://cr.openjdk.java.net/~aoqi/8222333/webrev.00/
>
> fastdebug build is broken after JDK-8221393. It seems that
> phase_mapping[] doesn't match enum Phase in WeakProcessorPhases
> anymore. Is this fix ok? I am not familiar with shenandoah.
> linux-x86_64-server-release hotspot:tier1 tested.
>
> Thanks,
> Ao Qi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190411/040a142d/attachment.htm>