RFR: JDK-8227039: Shenandoah: Aggressive heuristics for Traversal mode

[Aleksey Shipilev]

On 7/4/19 8:43 PM, Roman Kennke wrote:
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8227039/webrev.00/

*) Indenting at L52:

  49     if (strcmp(ShenandoahGCHeuristics, "adaptive") == 0) {
  50       return new ShenandoahTraversalHeuristics();
  51     } else if (strcmp(ShenandoahGCHeuristics, "aggressive") == 0) {
  52         return new ShenandoahTraversalAggressiveHeuristics();
  53     } else {

*) I'd say in test configuration the mode should come first, then heuristics. See for example:

http://cr.openjdk.java.net/~rkennke/JDK-8227039/webrev.00/test/hotspot/jtreg/gc/shenandoah/TestGCThreadGroups.java.sdiff.html

Otherwise looks fine.

-- 
Thanks,
-Aleksey