RFR: JDK-8227039: Shenandoah: Aggressive heuristics for Traversal mode

Roman Kennke rkennke at redhat.com
Fri Jul 5 08:59:33 UTC 2019


>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/JDK-8227039/webrev.00/
> 
> *) Indenting at L52:
> 
>   49     if (strcmp(ShenandoahGCHeuristics, "adaptive") == 0) {
>   50       return new ShenandoahTraversalHeuristics();
>   51     } else if (strcmp(ShenandoahGCHeuristics, "aggressive") == 0) {
>   52         return new ShenandoahTraversalAggressiveHeuristics();
>   53     } else {

Good catch! Fixed!

> *) I'd say in test configuration the mode should come first, then heuristics. See for example:
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8227039/webrev.00/test/hotspot/jtreg/gc/shenandoah/TestGCThreadGroups.java.sdiff.html

Right! Fixed it there and all other instances that I could find.

Incremental:
http://cr.openjdk.java.net/~rkennke/JDK-8227039/webrev.01/
Full:
http://cr.openjdk.java.net/~rkennke/JDK-8227039/webrev.01.full/

Testing: same as always ;-)

Ok?

Roman




More information about the hotspot-gc-dev mailing list