RFR (xs): 8221509: Refactor assert( G1CollectedHeap::used() == recalculate_used() ) with better message

[sangheon.kim at oracle.com]

Hi Man,

On 5/3/19 1:18 PM, Man Cao wrote:
> Hi Sangheon,
>
> The change looks good to me. I'm not an official "Reviewer" though.
Thanks for your review.
Thomas S. suggested to rename to 
'assert_used_and_recalculate_used_equal()' before pushing. No more 
webrev. :)
Hope you are okay with that.

Thanks,
Sangheon


>
> -Man
>
>
> *From: *<sangheon.kim at oracle.com <mailto:sangheon.kim at oracle.com>>
> *Date: *Tue, Apr 30, 2019 at 1:54 PM
> *To: *hotspot-gc-dev
>
>     Hi all,
>
>     Can I have some reviews that replace assert(used() ==
>     recalculated_used()) with better message?
>     Those assert messages are not much helpful as it doesn't include any
>     actual values on it so I'm suggesting to include actual values of
>     each
>     and then replace as a macro.
>
>     CR: https://bugs.openjdk.java.net/browse/JDK-8221509
>     webrev: http://cr.openjdk.java.net/~sangheki/8221509/webrev.0/
>     <http://cr.openjdk.java.net/%7Esangheki/8221509/webrev.0/>
>     testing: local build
>
>     Thanks,
>     Sangheon
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190506/e18c8d44/attachment.htm>