RFR (XS): 8233792: TestG1ParallelPhases.java fails with phase NonYoungFreeCSet not found (2)

[Thomas Schatzl]

Hi Kim, Leo,

   thanks for your reviews :)

On 11.11.19 17:45, Leo Korinth wrote:
> On 11/11/2019 16:44, Thomas Schatzl wrote:
>> Hi all,
>>
>>    can I have reviews for this small test fix to avoid this test 
>> failing sometimes?
>>[...]
>> The fix is to make sure that before forcing mixed gc (which works) we 
>> force the heap into a state where the upgrade to full gc may not 
>> happen - by forcing a full gc.
>>
>> Without the patch the fails like 6 times in 4000 runs, with the change 
>> it does not fail after 3k runs.
> 
> Looks good, thanks for finding and fixing this Thomas!
> 
> After looking at your fix, I also took a look at TestLogging.java and 
> TestOldGenCollectionUsage.java (from which I copied the code). Those 
> test cases does, in addition to this test case, also allocate in a loop 
> at the end and provokes a mixed gc by also setting 
> -XX:G1MixedGCLiveThresholdPercent=100. Even if those tests do "work", I 
> think those test cases ought to be cleaned up so that they do not fool 
> more people like me. If you think that is a good idea, I will create an 
> enhancement for cleanup of those test cases.

Sure, go ahead.

Thanks,
   Thomas