RFR(M): 8220311: Implementation: NUMA-Aware Memory Allocation for G1, Survivor (2/3)

[sangheon.kim at oracle.com]

Hi Kim,

Thanks for reviewing this part.

On 10/21/19 4:24 PM, Kim Barrett wrote:
>> On Oct 13, 2019, at 2:00 AM, sangheon.kim at oracle.com wrote:
>>
>> Hi all,
>>
>> Previous patch conflicts, so I'm posting rebased one.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sangheki/8220311/webrev.2
>> Testing: hs-tier 1 ~ 5, with/without UseNUMA
>>
>> Thanks,
>> Sangheon
> ------------------------------------------------------------------------------
> src/hotspot/share/gc/g1/g1ParScanThreadState.hpp
> Removed:
>   190   // ... State is the original (source) cset state for the object
>   191   // that is allocated for. ...
>
> That simple removal doesn't seem right. Now "state" in the next
> sentence has no explanation.  Maybe some better rewrite?
What do you think about below comment?

   // Tries to allocate word_sz in the PLAB of the next "generation" 
after trying to
   // allocate into dest. Previous_plab_refill_failed indicates whether 
previous
   // PLAB refill for the original (source) object was failed.
   // Returns a non-NULL pointer if successful, and updates dest if 
required.
   // Also determines whether we should continue to try to allocate into 
the various
   // generations or just end trying to allocate.
   HeapWord* allocate_in_next_plab(G1HeapRegionAttr* dest,
...

Let me post the webrev when we decide. :)

Thanks,
Sangheon


>
> ------------------------------------------------------------------------------
>
> Looks good, other than that one comment issue.
>