RFR(M): 8220311: Implementation: NUMA-Aware Memory Allocation for G1, Survivor (2/3)

[Kim Barrett]

> On Oct 22, 2019, at 1:52 AM, sangheon.kim at oracle.com wrote:
> What do you think about below comment?
> 
>   // Tries to allocate word_sz in the PLAB of the next "generation" after trying to
>   // allocate into dest. Previous_plab_refill_failed indicates whether previous
>   // PLAB refill for the original (source) object was failed.

Drop “was”.  Otherwise looks good.

>   // Returns a non-NULL pointer if successful, and updates dest if required.
>   // Also determines whether we should continue to try to allocate into the various
>   // generations or just end trying to allocate.
>   HeapWord* allocate_in_next_plab(G1HeapRegionAttr* dest,
> ...
> 
> Let me post the webrev when we decide. :)
> 
> Thanks,
> Sangheon
> 
> 
>> 
>> ------------------------------------------------------------------------------
>> 
>> Looks good, other than that one comment issue.