RFR (XS): 8232951: TestG1ParallelPhases.java fails with phase NonYoungFreeCSet not found

Stefan Johansson stefan.johansson at oracle.com
Mon Oct 28 08:35:53 UTC 2019


Hi Thomas,

> 26 okt. 2019 kl. 03:51 skrev Kim Barrett <kim.barrett at oracle.com>:
> 
>> On Oct 24, 2019, at 7:50 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>> […]
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8232951
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8232951/webrev/
>> Testing:
>> 400 runs of the changed test without issues
>> 
>> Thanks,
>> Thomas
> 
> I'd not previously noticed the AlwaysTenure and NeverTenure options.
> So many options...
> 
> Those options are documented as being ParallelGC only.  But it looks
> like setting either of them forces a value for MaxTenuringThreshold,
> so it seems okay to change the test to use AlwaysTenure.  The
> documentation for the options should be updated though.  (That can be
> a separate RFE.)
> 
> Please put the new -Xlog option on a separate line.  I know we don't
> have an official line length limit, but 152 chars seems excessive to
> me, and forced me to scroll to see some of it.
> 
> Other than that, looks good.  I don't need a new webrev.
> 

Sounds like a good fix and it looks good,
Stefan


More information about the hotspot-gc-dev mailing list