RFR 8232992: Shenandoah: Implement self-fixing interpreter LRB

Aleksey Shipilev shade at redhat.com
Mon Oct 28 14:49:23 UTC 2019


On 10/26/19 2:34 AM, Zhengyu Gu wrote:
> We only need to use rscratch1 when dst == r1, and there is possibility that dst comes in in
> rscratch1 (see SBSA::load_at() method), I think current assertion (dst != rscratch2) is sufficient.
> 
> However, we do need to ensure scratch registers are not used by load_addr, so added:
> 
>   assert_different_registers(load_addr.base(), load_addr.index(), rscratch1);
>   assert_different_registers(load_addr.base(), load_addr.index(), rscratch2);

Why not just:
  assert_different_registers(load_addr.base(), load_addr.index(), rscratch1, rscratch2);

> Updated: http://cr.openjdk.java.net/~zgu/JDK-8232992/webrev.01/

Looks fine to me otherwise.

-- 
Thanks,
-Aleksey




More information about the hotspot-gc-dev mailing list