RFR 8232992: Shenandoah: Implement self-fixing interpreter LRB

[Zhengyu Gu]

On 10/28/19 10:49 AM, Aleksey Shipilev wrote:
> On 10/26/19 2:34 AM, Zhengyu Gu wrote:
>> We only need to use rscratch1 when dst == r1, and there is possibility that dst comes in in
>> rscratch1 (see SBSA::load_at() method), I think current assertion (dst != rscratch2) is sufficient.
>>
>> However, we do need to ensure scratch registers are not used by load_addr, so added:
>>
>>    assert_different_registers(load_addr.base(), load_addr.index(), rscratch1);
>>    assert_different_registers(load_addr.base(), load_addr.index(), rscratch2);
> 
> Why not just:
>    assert_different_registers(load_addr.base(), load_addr.index(), rscratch1, rscratch2);

Yep, fixed and pushed.

Thanks,

-Zhengyu

> 
>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8232992/webrev.01/
> 
> Looks fine to me otherwise.
>