RFR(M): 8220311: Implementation: NUMA-Aware Memory Allocation for G1, Survivor (2/3)

Thomas Schatzl thomas.schatzl at oracle.com
Tue Oct 29 08:42:27 UTC 2019


Hi,

On 25.10.19 16:02, sangheon.kim at oracle.com wrote:
[...]
> 
> In addition, Stefan, Thomas and I had some discussion about making 
> PLAB-NUMA aware (only for survivor).
> Stefan provided a patch with it and it is simple enough to include under 
> this CR.
> 
> Webrev:
> http://cr.openjdk.java.net/~sangheki/8220311/webrev.4
> http://cr.openjdk.java.net/~sangheki/8220311/webrev.4.inc
> 
> Testing: hs-tier 1 ~ 3, with/without UseNUMA
> 
> Thanks,
> Sangheon
> 
> 

- G1Allocator::nodes() -> G1Allocator::num_nodes()

- g1Allocator.hpp:167: s/depend/depending

- please file an RFE investigating adding the node index to the region 
attributes

Looks good otherwise. I do not need a re-review for these changes.

Thomas



More information about the hotspot-gc-dev mailing list