RFR(M): 8220311: Implementation: NUMA-Aware Memory Allocation for G1, Survivor (2/3)

[sangheon.kim at oracle.com]

Hi Thomas,

On 10/29/19 1:42 AM, Thomas Schatzl wrote:
> Hi,
>
> On 25.10.19 16:02, sangheon.kim at oracle.com wrote:
> [...]
>>
>> In addition, Stefan, Thomas and I had some discussion about making 
>> PLAB-NUMA aware (only for survivor).
>> Stefan provided a patch with it and it is simple enough to include 
>> under this CR.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sangheki/8220311/webrev.4
>> http://cr.openjdk.java.net/~sangheki/8220311/webrev.4.inc
>>
>> Testing: hs-tier 1 ~ 3, with/without UseNUMA
>>
>> Thanks,
>> Sangheon
>>
>>
>
> - G1Allocator::nodes() -> G1Allocator::num_nodes()
Done.

>
> - g1Allocator.hpp:167: s/depend/depending
Done.

>
> - please file an RFE investigating adding the node index to the region 
> attributes
Filed https://bugs.openjdk.java.net/browse/JDK-8233149: Investigate 
adding node index at G1HeapRegionAttr.

>
> Looks good otherwise. I do not need a re-review for these changes.
Thanks for your review.

Sangheon


>
> Thomas