RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v9]

[Thomas Stuefe]

On Sat, 3 Oct 2020 21:34:46 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Misc. Review feedback
>>  - Move ClassLoaderMetaspace to own include and correct includes
>
> src/hotspot/share/memory/metaspace/chunkManager.cpp line 144:
> 
>> 142:   DEBUG_ONLY(chunklevel::check_valid_level(max_level);)
>> 143:   DEBUG_ONLY(chunklevel::check_valid_level(preferred_level);)
>> 144:   assert(max_level >= preferred_level, "invalid level.");
> 
> This assert is redundant. It has the same condition as the assert on line 135.

True.

(The line numbers are off in this snippet btw. The real code is at 125ff. Not sure what happened.)

> src/hotspot/share/memory/metaspace/rootChunkArea.cpp line 110:
> 
>> 108:   // half chunk splinter.
>> 109:   // Instead, just split split split and delay building up the double linked list of the
>> 110:   // new chunks at the end of all splits.
> 
> This comment does not match the code below anymore, does it?

Right, good catch, this was for an earlier version. Found the original code too hard to read and too error prone. I'll
remove the comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336