RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v9]

[Richard Reingruber]

On Mon, 5 Oct 2020 12:42:22 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> True.
> 
> (The line numbers are off in this snippet btw. The real code is at 125ff. Not sure what happened.)

This is what I meant in my review-message:

> > Btw: I couldn't find out how to navigate from one of my comments to the line of code. At least, when I click on the
> > file name, this brings me to a view of the patch at the version I commented on so the line numbers are correct even if
> > they changed in the head revision of the pr.
> 
> The line of code a comment applies to is the lowest in the code excerpt shown atop of the comment. Unless the comment
> applied to multiple lines, then it shows (eg "Comment on lines +105 to +110").

If you click on the `chunkManager.cpp` in the comment header, this will bring you to the version of the file I
commented on, and the line numbers there should match the numbers in the comment's code snippet. You will also see the
this comment there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336