RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v11]

[Thomas Stuefe]

On Mon, 5 Oct 2020 20:39:28 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review Feedback Richard 1
>
> src/hotspot/share/memory/metaspace/metachunk.cpp line 141:
> 
>> 139: void Metachunk::uncommit() {
>> 140:   MutexLocker cl(MetaspaceExpand_lock, Mutex::_no_safepoint_check_flag);
>> 141:   uncommit_locked();
> 
> `uncommit()` seems to be unused.

It is used in a number of gtests. I'd prefer to keep it since otherwise I would have to lock manually each time there,
and also because of symmetry with other functions.

> src/hotspot/share/memory/metaspace/freeChunkList.hpp line 69:
> 
>> 67: //    uncommitted or committed to at least one commit granule size).
>> 68: //  - in all likelihood chunks, when added to this list, are either fully committed
>> 69: //    or fully uncommitted (see Settings::uncommit_on_return_min_word_size()).
> 
> `Settings::uncommit_on_return_min_word_size()` does not exist.

Leftover. Will remove the reference.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336