RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v11]

Richard Reingruber rrich at openjdk.java.net
Tue Oct 6 13:40:16 UTC 2020


On Tue, 6 Oct 2020 12:03:34 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/share/memory/metaspace/metachunk.cpp line 141:
>> 
>>> 139: void Metachunk::uncommit() {
>>> 140:   MutexLocker cl(MetaspaceExpand_lock, Mutex::_no_safepoint_check_flag);
>>> 141:   uncommit_locked();
>> 
>> `uncommit()` seems to be unused.
>
> It is used in a number of gtests. I'd prefer to keep it since otherwise I would have to lock manually each time there,
> and also because of symmetry with other functions.

Ok, I see.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336



More information about the hotspot-gc-dev mailing list