RFR: 8252221: Use multiple workers for Parallel GC pre-touching

[Thomas Schatzl]

Hi Amit,

On 06.10.20 20:14, Amit Pawar wrote:
> On Mon, 28 Sep 2020 04:11:16 GMT, Amit Pawar <github.com+71302734+amitdpawar at openjdk.org> wrote:
> 
>> Thanks for agreeing and will update the PR with suggested changes for final review.
>>
>> Thanks,
>> Amit
> 
> Hi Thomas,
> 
> PR is updated with suggested changes. Please review.
> 
> Thanks,
> Amit


   looks really good now, some minor nits:

- g1PageBasedVirtualSpace.cpp/mutableSpace.cpp: please keep the include 
declarations sorted

- mutableSpace.cpp:118+

  PretouchTask::pretouch("ParallelGC PreTouch", (char*)head.start(),
                         (char*)head.end(), page_size, pretouch_gang);

  PretouchTask::pretouch("ParallelGC PreTouch", (char*)tail.start(),
                         (char*)tail.end(), page_size, pretouch_gang);

  - Please move the end_address parameter to the previous line even if 
it crosses 80 chars.
  - the two tasks could be named differently, i.e. "ParallelGC PreTouch 
head" and "... tail"

- pretouch.hpp: s/2018/2020 in the header; maybe update the end dates of 
the other files too.

I'll let it pass through testing over the weekend. I will report back if 
there is anything problematic.

Thanks,
   Thomas