RFR: 8255131: G1CollectedHeap::is_in() returns wrong result [v2]
Thomas Schatzl
tschatzl at openjdk.java.net
Thu Oct 22 11:30:30 UTC 2020
> Hi all,
>
> please review this change to exchange the broken G1CollectedHeap::is_in() by G1CollectedHeap::is_in_exact() that has the same performance profile and correct.
>
> G1CollectedHeap::is_in() returns true for any region ever committed (and crashes for not yet committed regions), while is_in_exact() (almost) did the right thing. Almost because HeapRegionManager::is_available() would assert if the given pointer is outside the heap and it's not guarded by is_in_reserved.
>
> Test: tier1
>
> Thanks,
> Thomas
Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
kbarrett, ayang reviews
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/799/files
- new: https://git.openjdk.java.net/jdk/pull/799/files/0fa2e85c..df181bba
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=799&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=799&range=00-01
Stats: 6 lines in 1 file changed: 0 ins; 5 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/799.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/799/head:pull/799
PR: https://git.openjdk.java.net/jdk/pull/799
More information about the hotspot-gc-dev
mailing list