RFR: 8255131: G1CollectedHeap::is_in() returns wrong result [v2]

[Thomas Schatzl]

On Thu, 22 Oct 2020 11:03:13 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   kbarrett, ayang reviews
>
> Changes requested by kbarrett (Reviewer).

Changed as requested.

Had a discussion with ayang about the specification of CollectedHeap::is_in(): it reads
``
  // Returns "TRUE" iff "p" points into the committed areas of the heap.
  // This method can be expensive so avoid using it in performance critical
  // code.
 ``
but ZGC also checks if p is < top() within the region. This seems a good idea, but needs a change of that "specification" (and more testing although I think G1 fulfills that as well), so I'd like to postpone this change for now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/799