RFR: 8264423: G1: Rename full gc attribute table states

Thomas Schatzl tschatzl at openjdk.java.net
Wed Apr 14 08:43:12 UTC 2021


Hi all,

  please review this cleanup change suggested in PR#2760 that renames some code in the g1 full gc attribute table.

This is the description from the CR:

>  Since JDK-8253600 g1 full gc has its own (temporary) attribute table storing information that it needs for evacuation.
> 
> Currently the naming corresponds to the attributes in HeapRegion. This is somewhat confusing, as they do not completely match.
> 
> While discussing this in the review for JDK-8262068 we thought of changing this to more reflect the purpose:
> 
> I.e.
> closed -> not_marked_through (or "always live" or "always_marked" something similar to indicate that we do not need to mark through them)
> pinned -> not_compacted
> normal -> compacted (or just keep "normal" as it is some internal state) 

Some additional renaming has been performed.

Testing: tier1-5

-------------

Commit messages:
 - Some more renamings
 - Initial version for testing

Changes: https://git.openjdk.java.net/jdk/pull/3486/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3486&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264423
  Stats: 66 lines in 8 files changed: 4 ins; 16 del; 46 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3486.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3486/head:pull/3486

PR: https://git.openjdk.java.net/jdk/pull/3486



More information about the hotspot-gc-dev mailing list