RFR: 8264423: G1: Rename full gc attribute table states [v2]
Thomas Schatzl
tschatzl at openjdk.java.net
Wed Apr 14 10:55:10 UTC 2021
> Hi all,
>
> please review this cleanup change suggested in PR#2760 that renames some code in the g1 full gc attribute table.
>
> This is the description from the CR:
>
>> Since JDK-8253600 g1 full gc has its own (temporary) attribute table storing information that it needs for evacuation.
>>
>> Currently the naming corresponds to the attributes in HeapRegion. This is somewhat confusing, as they do not completely match.
>>
>> While discussing this in the review for JDK-8262068 we thought of changing this to more reflect the purpose:
>>
>> I.e.
>> closed -> not_marked_through (or "always live" or "always_marked" something similar to indicate that we do not need to mark through them)
>> pinned -> not_compacted
>> normal -> compacted (or just keep "normal" as it is some internal state)
>
> Some additional renaming has been performed.
>
> Testing: tier1-5
Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
sjohanss review - remove double negation
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3486/files
- new: https://git.openjdk.java.net/jdk/pull/3486/files/f0faf8a9..2047bc11
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3486&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3486&range=00-01
Stats: 18 lines in 4 files changed: 5 ins; 8 del; 5 mod
Patch: https://git.openjdk.java.net/jdk/pull/3486.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3486/head:pull/3486
PR: https://git.openjdk.java.net/jdk/pull/3486
More information about the hotspot-gc-dev
mailing list