RFR: 8264423: G1: Rename full gc attribute table states [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Wed Apr 14 12:19:06 UTC 2021


On Wed, 14 Apr 2021 12:05:48 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   sjohanss review - remove double negation
>
> src/hotspot/share/gc/g1/g1FullGCHeapRegionAttr.hpp line 71:
> 
>> 69:   }
>> 70: 
>> 71:   bool is_compacted_or_marked_through(uint idx) const {
> 
> Should this be rename to is_compacted_or_not_marked_through?
> As the condition is indeed == Compacted || == NotMarkedThrough.

Yes, that's true. It should actually be called `is_compacted_or_not_marked_through`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3486



More information about the hotspot-gc-dev mailing list