RFR: 8272609: Add string deduplication support to SerialGC [v2]

Kim Barrett kbarrett at openjdk.java.net
Thu Aug 19 23:54:26 UTC 2021


On Thu, 19 Aug 2021 09:14:55 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi team,
>> 
>> Please help review this change to add string deduplication support to SerialGC.
>> 
>> Thanks,
>> Denghui
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   avoid non-local variables with non-trivial / not-constexpr constructors or destructors

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp line 198:

> 196: // is completed the Requests object must be flushed (either explicitly or by
> 197: // the destructor).
> 198: class StringDedup::Requests : public ResourceObj {

Should be `CHeapObj<mtGC>` rather than `ResourceObj`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5153



More information about the hotspot-gc-dev mailing list