RFR: 8272609: Add string deduplication support to SerialGC [v2]

[Kim Barrett]

On Thu, 19 Aug 2021 09:14:55 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi team,
>> 
>> Please help review this change to add string deduplication support to SerialGC.
>> 
>> Thanks,
>> Denghui
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   avoid non-local variables with non-trivial / not-constexpr constructors or destructors

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/serial/serialStringDedup.hpp line 46:

> 44:                                            bool obj_is_tenured) {
> 45:     return StringDedup::is_enabled() &&
> 46:            java_lang_String::is_instance_inlined(java_string) &&

Missing `#include` for this function.  A bunch of the pre-submit builds on github are failing because of this.  To call this function will require including javaClasses.inline.hpp, and ".inline.hpp" files cannot be included by an ordinary ".hpp".  Dealing with this will require adding "gc/serial/stringDedup.inline.hpp", moving this definition there, &etc.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5153