RFR: 8272609: Add string deduplication support to SerialGC [v10]

[Kim Barrett]

On Sat, 21 Aug 2021 16:40:35 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thanks for your review and Kim's detailed explanation.
>> 
>> I think putting this invocation here or the position you suggest should have no effect on the result, so I tend not to make this modification.
>
> I believe it's desirable to narrow the request window (btw first `add` and `flush`), which offers more prompt string-dedup and memory release (in `flush`). Additionally, it makes more sense to call `flush` right after the complete live objects traversal  (strong-marking + final-marking as part of ref-processing), since we will not visit any new objects then.

I prefer it where it is.  Rather than putting something between phantom
reference processing an oopstorage-based weak processing, I would prefer to
merge those two.  I don't remember if there's an RFE for that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5153