RFR: 8258382: Fix optimization-unstable code involving pointer overflow [v2]

Kim Barrett kbarrett at openjdk.java.net
Mon Jan 4 04:04:54 UTC 2021


On Fri, 1 Jan 2021 07:11:32 GMT, Hao Sun <github.com+16932759+shqking at openjdk.org> wrote:

>> Thanks for splitting up the changes.  The GC changes look good.
>
> @kimbarrett thanks for your review.

This change should not have been pushed with only one review.  HotSpot changes normally require two reviews.
https://wiki.openjdk.java.net/display/HotSpot/Pushing+a+HotSpot+change

I know the skara bots said it was ready to go. They haven't yet been taught about such project-specific tailorings of the base process.  (The information in that page has supposedly been superseded by the new Developers' Guide (https://openjdk.java.net/guide/index.html), but the HotSpot reviewer requirements seem to have not made the transition.  I'll bring that up with the dev-guide folks.)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1886



More information about the hotspot-gc-dev mailing list