RFR: 8258534: Epsilon: clean up unused includes
Lehua Ding
github.com+13173904+lhtin at openjdk.java.net
Tue Jan 5 04:47:56 UTC 2021
On Mon, 4 Jan 2021 09:41:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> On the second look, the `#include` for `macro.hpp` is indeed excessive: `COMPILER1` and `COMPILER2` are already defined, so the rest of the `#include`-s should work fine. The only reason we would want that include if Epsilon used any of the extended definitions like `COMPILER2_ONLY`, but it does not.
>
> The patch looks good then. Please make sure you run the pre-integration tests. To do that, GH Actions should be enabled here: https://github.com/lhtin/jdk/actions -- and then probably triggered manually on your branch. Then "Checks" tab should have the test results. Once that is done, I would formally approve.
Thank you for your review and guide of test.
The pre-integration test has finished.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1745
More information about the hotspot-gc-dev
mailing list