RFR: 8273492: Move evacuation failure handling into G1YoungCollector

[Stefan Johansson]

On Wed, 8 Sep 2021 15:09:25 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this change that moves young gc evacuation failure handling (`G1EvacFailureRegions`) from `G1CollectedHeap` to `G1YoungCollector`.
> 
> Testing: tier1-3
> 
> Thanks,
>   Thomas

Looks good in general, just one question.

src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp line 490:

> 488:   trace_phase(_gc_par_phases[RedirtyCards]);
> 489:   debug_time("Post Evacuate Cleanup 2", _cur_post_evacuate_cleanup_2_time_ms);
> 490:   if (_gc_par_phases[RestorePreservedMarks]->uninitialized()) {

This looks a bit strange, why isn't this check using the passed in `evacuation_failed` like above? And if it can't shouldn't the check be `!_gc_par_phases[RestorePreservedMarks]->uninitialized()`?

-------------

Changes requested by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5419