RFR: 8273492: Move evacuation failure handling into G1YoungCollector

Thomas Schatzl tschatzl at openjdk.java.net
Mon Sep 20 11:24:57 UTC 2021


On Mon, 20 Sep 2021 09:55:30 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that moves young gc evacuation failure handling (`G1EvacFailureRegions`) from `G1CollectedHeap` to `G1YoungCollector`.
>> 
>> Testing: tier1-3
>> 
>> Thanks,
>>   Thomas
>
> src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp line 490:
> 
>> 488:   trace_phase(_gc_par_phases[RedirtyCards]);
>> 489:   debug_time("Post Evacuate Cleanup 2", _cur_post_evacuate_cleanup_2_time_ms);
>> 490:   if (_gc_par_phases[RestorePreservedMarks]->uninitialized()) {
> 
> This looks a bit strange, why isn't this check using the passed in `evacuation_failed` like above? And if it can't shouldn't the check be `!_gc_par_phases[RestorePreservedMarks]->uninitialized()`?

Probably some oversight when implementing some variants in that area. Will fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5419



More information about the hotspot-gc-dev mailing list