RFR: 8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references

Thomas Schatzl tschatzl at openjdk.java.net
Tue Sep 28 09:44:40 UTC 2021


Hi all,

  please review this backout of JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references because it causes failures with Kitchensink runs.

As the CR indicates, with proper verification these runs fail fairly quickly after 5-20mins with a remembered set verification failure on the discovered field of some j.l.ref.References instances; without that patch multiple instances are already running for an hour without issue (out of 8h). This is enough evidence for me that the change is responsible, backing it out to keep the CI clean(er) as I do not really have an idea why at this time (another merge issue after splitting up the original change?).

Revert applied cleanly except for the hunk in G1PostEvacuateCollectionSetCleanupTask1::G1PostEvacuateCollectionSetCleanupTask1 line 138: an earlier cleanup moved evacuation failure handling to `G1YoungCollector`, causing some merge problems.

Testing: gha

Thanks,
  Thomas

-------------

Commit messages:
 - Revert "8271880: Tighten condition for excluding regions from collecting cards with cross-references"

Changes: https://git.openjdk.java.net/jdk/pull/5734/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5734&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274340
  Stats: 171 lines in 14 files changed: 74 ins; 76 del; 21 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5734.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5734/head:pull/5734

PR: https://git.openjdk.java.net/jdk/pull/5734



More information about the hotspot-gc-dev mailing list