RFR: 8274430: Remove some debug error printing code added in JDK-8017163
Stefan Johansson
sjohanss at openjdk.java.net
Wed Sep 29 12:46:33 UTC 2021
On Tue, 28 Sep 2021 08:59:23 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that undoes some logging changes from JDK-8017163, in particular it added the `XXX card set` lines in the output as shown in an example below:
>
> ``` [171.616s][1632757560415ms][error][gc,verify ] GC(129) Missing rem set entry:
> [171.616s][1632757560415ms][error][gc,verify ] GC(129) Field 0x00000007fb1008f0 of obj 0x00000007fb1008d8 in region 1485:(O)[0x00000007fb000000,0x00000
> [171.616s][1632757560415ms][error][gc,verify ] GC(129) NULL card setjava.lang.invoke.MethodType$ConcurrentWeakInternSet$WeakEntry
> [...]
> points to obj 0x00000004d9abd4c8 in region 683:(S)[0x00000004d9000000,0x00000004da000000,0x00000004da000000] remset Complete
>
>
> This string would indicate which card set container does not have the requested remembered set entry. This is unnecessary information, as the "points to obj" string later shows that there should be a remset to this region already, and otherwise only interesting for debugging.
>
> Testing: gha
>
> Thanks,
> Thomas
Looks good.
-------------
Marked as reviewed by sjohanss (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5733
More information about the hotspot-gc-dev
mailing list