RFR: 8297285: Shenandoah pacing causes assertion failure during VM initialization [v2]

[Paul Hohensee]

On Thu, 24 Nov 2022 23:53:44 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> Please review the fix for the assertion failure seen during VM init due to pacing in shenandoah gc.
>> The fix is to avoid pacing during VM initialization as the main thread is not yet an active java thread.
>> 
>> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Include runtime/javaThread.inline.hpp for JavaThread::is_terminated() to
>   fix compile failure
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

I'm not familiar with this code, so please bear with me. :) The comment on line 246 says "Thread which is not an active Java thread should also not block.", but the check at line 251 will return (i.e., looks like not block) if the current thread is an active Java thread. Should the check be !current->is_active_Java_thread() instead?

-------------

PR: https://git.openjdk.org/jdk/pull/11360