RFR: 8297285: Shenandoah pacing causes assertion failure during VM initialization [v2]

[Ashutosh Mehra]

On Fri, 2 Dec 2022 00:17:00 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Include runtime/javaThread.inline.hpp for JavaThread::is_terminated() to
>>   fix compile failure
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> I'm not familiar with this code, so please bear with me. :) The comment on line 246 says "Thread which is not an active Java thread should also not block.", but the check at line 251 will return (i.e., looks like not block) if the current thread is an active Java thread. Should the check be !current->is_active_Java_thread() instead?

@phohensee you are right. It should be `!current->is_active_Java_thread()`, how did I miss that `!`!
Thanks for catching it in time.

-------------

PR: https://git.openjdk.org/jdk/pull/11360