RFR: 8282763: G1: G1CardSetContainer remove intrusive-list details. [v2]

Kim Barrett kbarrett at openjdk.java.net
Thu Mar 10 14:44:46 UTC 2022


On Wed, 9 Mar 2022 21:52:27 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this trivial cleanup to remove unnecessary G1CardSetContainer list details.
>> 
>> Testing: tier 1
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup includes

Looks good.  Just an include nit.

src/hotspot/share/gc/g1/g1CardSetContainers.hpp line 29:

> 27: 
> 28: #include "gc/g1/g1CardSet.hpp"
> 29: #include "memory/allocation.hpp"

allocation.hpp is used here - StackObj.  (We really ought to move that into it's own file, as was done for AllStatic.  It's a bit more complicated because of AllocatedObj.)  Presumably it's being picked up indirectly, but "include what you use".  (Hm, I thought that was in the style guide.  But not there yet - JDK-8252896.)

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7743



More information about the hotspot-gc-dev mailing list