RFR: 8282763: G1: G1CardSetContainer remove intrusive-list details. [v3]

Ivan Walulya iwalulya at openjdk.java.net
Thu Mar 10 14:49:20 UTC 2022


On Thu, 10 Mar 2022 14:40:19 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix includes
>
> src/hotspot/share/gc/g1/g1CardSetContainers.hpp line 29:
> 
>> 27: 
>> 28: #include "gc/g1/g1CardSet.hpp"
>> 29: #include "logging/log.hpp"
> 
> allocation.hpp is used here - StackObj.  (We really ought to move that into it's own file, as was done for AllStatic.  It's a bit more complicated because of AllocatedObj.)  Presumably it's being picked up indirectly, but "include what you use".  (Hm, I thought that was in the style guide.  But not there yet - JDK-8252896.)

Thanks @kimbarrett I missed that

-------------

PR: https://git.openjdk.java.net/jdk/pull/7743



More information about the hotspot-gc-dev mailing list