RFR: 8286943: G1: With virtualized remembered sets, maximum number of cards configured is wrong

Albert Mingkun Yang ayang at openjdk.java.net
Thu May 19 14:39:56 UTC 2022


On Wed, 18 May 2022 15:22:03 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I get reviews for this change that fixes passing a wrong parameter value to card set configuration that
> 
> * prevents upgrading a Howl container to Full with virtualized remembered sets (Heap regions >= 64M) as the (default) threshold for coarsening from Howl to Full is max_cards_in_cardset * 0.9, which is always higher than the value tested against (65k, max card set container element number).
> * and also unnecessarily increases the bits used for inline ptrs
> 
> I added some basic parameter verification to the main constructor which would have caught this issue.
> 
> Testing: gha, tier1-3
> 
> Thanks,
>   Thomas

Marked as reviewed by ayang (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8773



More information about the hotspot-gc-dev mailing list